Skip to content

Don't fail on convergence trial reporting #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't fail on convergence trial reporting #329

wants to merge 1 commit into from

Conversation

Fatsie
Copy link
Contributor

@Fatsie Fatsie commented Aug 18, 2022

When ngspice tries an alternative DC converge algorithm it reports the
progress on stderr. This patch makes PySpice not error out when the
alternative DC convergence has been reported to be successful.

Example of report on stderr from spice that previously raised an exception:

Note: Starting dynamic gmin stepping
Trying gmin =   1.0000E-03 Note: One successful gmin step
Trying gmin =   1.0000E-04 Note: One successful gmin step
Trying gmin =   1.0000E-05 Note: One successful gmin step
Trying gmin =   1.0000E-06 Note: One successful gmin step
Trying gmin =   1.0000E-07 Note: One successful gmin step
Trying gmin =   1.0000E-08 Note: One successful gmin step
Trying gmin =   1.0000E-09 Note: One successful gmin step
Trying gmin =   1.0000E-10 Note: One successful gmin step
Trying gmin =   1.0000E-11 Note: One successful gmin step
Trying gmin =   1.0000E-12 Note: One successful gmin step
Trying gmin =   1.0000E-12 Note: One successful gmin step
Note: Dynamic gmin stepping completed

I also saw source stepping that ended with Note: ... finished successfully

@FatsieFS
Don't fail on convergence trial reporting
234745a 
When ngspice tries an alternative DC converge algorithm it reports the
progress on stderr. This patch makes PySpice not error out when the
alternative DC convergence has been reported to be successful.
@FatsieFS FatsieFS deleted the stderr_nofail branch February 9, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fatsie @FatsieFS